Fix errcheck related to type assertion #654
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that errcheck was returning an error by running
make lint
.It seems to be caused by missing return value checks in a type assertion.
Error return value is not checked (errcheck)
Steps to Reproduce
What I Did
I addressed the root cause of the errcheck issue by adding conditional branching to the type assertion.
I decided to keep the function signature the same.
Although ignoring the error could be an option to avoid redundant error handling, I decided to handle it properly rather than ignoring it carelessly.
What I confirmed
make lint
Others
This is my first PR to tbls.
I often use tbls because they are easy to use and useful.
Thanks for tbls. :D